Skip to content

[migration] recoveryservicesbackup to TypeSpec #35709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 48 commits into from
Sep 23, 2025
Merged

[migration] recoveryservicesbackup to TypeSpec #35709

merged 48 commits into from
Sep 23, 2025

Conversation

tadelesh
Copy link
Member

@tadelesh tadelesh commented Jul 7, 2025 •
edited
Loading

Remaining problems:
- LRO operation without any response headers
- Multiple layer discriminated types.
- Param ordering

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 7, 2025 •
edited by scbedd
Loading

This comment is a remnant of a now-deprecated bot framework. It is being left behind only to point at the new comment that is updated by our new actions-based framework.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 7, 2025 •
edited
Loading

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

@github-actions
Copy link

github-actions bot commented Jul 7, 2025 •
edited
Loading

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Swagger Microsoft.RecoveryServices
TypeSpec Microsoft.RecoveryServices
Java com.azure.resourcemanager:azure-resourcemanager-recoveryservicesbackup
Go sdk/resourcemanager/recoveryservices/armrecoveryservicesbackup

@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview resource-manager TypeSpec Authored with TypeSpec WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 7, 2025
@AzureRestAPISpecReview AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required NotReadyForARMReview and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 8, 2025
tadelesh added 2 commits September 19, 2025 16:41
@tadelesh tadelesh force-pushed the recovery_service_backup_typespec branch from 60acb1e to 4f34bb4 Compare September 23, 2025 08:23
@pshao25 pshao25 added the BreakingChange-Approved-Benign Changes are not breaking at the REST API level and have at most minor impact to generated SDKs. label Sep 23, 2025
@github-actions github-actions bot added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed NotReadyForARMReview labels Sep 23, 2025
@pshao25 pshao25 added Approved-LintDiff ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review labels Sep 23, 2025
@github-actions github-actions bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 23, 2025
@pshao25 pshao25 added PublishToCustomers Acknowledgement the changes will be published to Azure customers. BreakingChange-Go-Sdk-Approved labels Sep 23, 2025
lirenhe
lirenhe approved these changes Sep 23, 2025
View reviewed changes
Copy link
Member

@lirenhe lirenhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JS failed because of a known issue, not a blocker for this PR merge.
So force merge this PR.

@lirenhe lirenhe merged commit b4146f9 into main Sep 23, 2025
53 of 59 checks passed
@lirenhe lirenhe deleted the recovery_service_backup_typespec branch September 23, 2025 09:34
@QixiaLu QixiaLu mentioned this pull request Oct 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mzhongl524 mzhongl524 mzhongl524 left review comments

@weidongxu-microsoft weidongxu-microsoft weidongxu-microsoft left review comments

@v-jiaodi v-jiaodi v-jiaodi left review comments

@lirenhe lirenhe lirenhe approved these changes

@pshao25 pshao25 pshao25 approved these changes

@weshaggard weshaggard Awaiting requested review from weshaggard

@mikeharder mikeharder Awaiting requested review from mikeharder

Assignees

No one assigned

Labels

Approved-LintDiff ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Approved-Benign Changes are not breaking at the REST API level and have at most minor impact to generated SDKs. BreakingChange-Go-Sdk BreakingChange-Go-Sdk-Approved BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required PipelineBotTrigger PublishToCustomers Acknowledgement the changes will be published to Azure customers. Recovery Services Backup resource-manager TypeSpec Authored with TypeSpec

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@tadelesh @XiaofeiCao @weidongxu-microsoft @lirenhe @mzhongl524 @v-jiaodi @pshao25 @AzureRestAPISpecReview @msyyc